make it look more OpenCV-ish#4
Open
nlgranger wants to merge 4 commits intostbnps:masterfrom
nlgranger:master
Open
make it look more OpenCV-ish#4nlgranger wants to merge 4 commits intostbnps:masterfrom nlgranger:master
nlgranger wants to merge 4 commits intostbnps:masterfrom
nlgranger:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Your implementation of the generalized distance transform seems to be the best one available for OpenCV as of today. Furthermore, it is mentioned as a solution in the (still open) bug report at opencv/opencv#4696.
Why not trying to merge this project upstream in the OpenCV extra modules? I am not an OpenCV expert, but I think this pull request makes a step toward the OpenCV style.
Note: for my personal needs, I am probably going to work on a CMake configuration file and a python binding so that the project can be used as a standalone library.
Best regards,
Nicolas